]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: mdio: adapt debug output
authorMarkus Stockhausen <markus.stockhausen@gmx.de>
Tue, 7 Apr 2026 16:22:08 +0000 (18:22 +0200)
committerRobert Marko <robimarko@gmail.com>
Thu, 9 Apr 2026 08:46:37 +0000 (10:46 +0200)
Now that the driver drives multiple busses adapt the debug output
from port based to bus/phy based.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/22830
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c

index 6677c38fa9f36bccd4e46e4b029dbc5783b96c87..0a63d64deb1107083c41821f0b33eaf4fbb6c54a 100644 (file)
@@ -527,8 +527,8 @@ static int rtmdio_read_c45(struct mii_bus *bus, int phy, int devnum, int regnum)
 
        guard(mutex)(&ctrl->lock);
        err = (*ctrl->cfg->read_mmd_phy)(bus, addr, devnum, regnum, &val);
-       pr_debug("rd_MMD(adr=%d, dev=%d, reg=%d) = %d, err = %d\n",
-                addr, devnum, regnum, val, err);
+       dev_dbg(&bus->dev, "rd_MMD(phy=0x%02x, dev=0x%04x, reg=0x%04x) = 0x%04x, err = %d\n",
+               phy, devnum, regnum, val, err);
 
        return err ? err : val;
 }
@@ -549,8 +549,8 @@ static int rtmdio_read(struct mii_bus *bus, int phy, int regnum)
        ctrl->port[addr].raw = (ctrl->port[addr].page == ctrl->cfg->raw_page);
 
        err = (*ctrl->cfg->read_phy)(bus, addr, ctrl->port[addr].page, regnum, &val);
-       pr_debug("rd_PHY(adr=%d, pag=%d, reg=%d) = %d, err = %d\n",
-                addr, ctrl->port[addr].page, regnum, val, err);
+       dev_dbg(&bus->dev, "rd_PHY(phy=0x%02x, pag=0x%04x, reg=0x%04x) = 0x%04x, err = %d\n",
+               phy, ctrl->port[addr].page, regnum, val, err);
 
        return err ? err : val;
 }
@@ -566,8 +566,8 @@ static int rtmdio_write_c45(struct mii_bus *bus, int phy, int devnum, int regnum
 
        guard(mutex)(&ctrl->lock);
        err = (*ctrl->cfg->write_mmd_phy)(bus, addr, devnum, regnum, val);
-       pr_debug("wr_MMD(adr=%d, dev=%d, reg=%d, val=%d) err = %d\n",
-                addr, devnum, regnum, val, err);
+       dev_dbg(&bus->dev, "wr_MMD(phy=0x%02x, dev=0x%04x, reg=0x%04x, val=0x%04x), err = %d\n",
+               phy, devnum, regnum, val, err);
 
        return err;
 }
@@ -592,8 +592,9 @@ static int rtmdio_write(struct mii_bus *bus, int phy, int regnum, u16 val)
                ctrl->port[addr].raw = (page == ctrl->cfg->raw_page);
 
                err = (*ctrl->cfg->write_phy)(bus, addr, page, regnum, val);
-               pr_debug("wr_PHY(adr=%d, pag=%d, reg=%d, val=%d) err = %d\n",
-                        addr, page, regnum, val, err);
+               dev_dbg(&bus->dev,
+                       "wr_PHY(phy=0x%02x, pag=0x%04x, reg=0x%04x, val=0x%04x), err = %d\n",
+                       phy, page, regnum, val, err);
                return err;
        }