]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
HID: Intel-thc-hid: Intel-quicki2c: Use put_unaligned_le16 for __le16 writes
authorEven Xu <even.xu@intel.com>
Tue, 9 Dec 2025 07:52:13 +0000 (15:52 +0800)
committerJiri Kosina <jkosina@suse.com>
Wed, 7 Jan 2026 21:03:47 +0000 (22:03 +0100)
Replace memcpy operations with put_unaligned_le16() when writing 16-bit
little-endian values to the write buffer.

This change improves code clarity and ensures proper handling of unaligned
memory access.

Signed-off-by: Even Xu <even.xu@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-thc-hid/intel-quicki2c/quicki2c-protocol.c

index 013cbbb39efd2ff7ff9b45f5716c4d559e01cbca..ab390ce79c213e612fe53adeac3bd80ae28408e4 100644 (file)
@@ -41,9 +41,7 @@ static ssize_t quicki2c_init_write_buf(struct quicki2c_device *qcdev, u32 cmd, s
        }
 
        if (data && data_len) {
-               __le16 len = cpu_to_le16(data_len + HIDI2C_LENGTH_LEN);
-
-               memcpy(write_buf + offset, &len, HIDI2C_LENGTH_LEN);
+               put_unaligned_le16(data_len + HIDI2C_LENGTH_LEN, write_buf + offset);
                offset += HIDI2C_LENGTH_LEN;
                memcpy(write_buf + offset, data, data_len);
        }