]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
memory: tegra114-emc: Do not print error on icc_node_create() failure
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Mon, 4 May 2026 19:00:05 +0000 (21:00 +0200)
committerKrzysztof Kozlowski <krzk@kernel.org>
Thu, 14 May 2026 16:35:30 +0000 (18:35 +0200)
icc_node_create() isĀ alloc-like function, so no need to print error
messages on its failure.  Dropping one label makes the code a bit
simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260504190004.747509-3-krzysztof.kozlowski@oss.qualcomm.com
drivers/memory/tegra/tegra114-emc.c

index fc3bf1a286307fdaea199dccdc614de895e84b9b..559ce47694a5debf0cebefeee56277c1a1961fb6 100644 (file)
@@ -1204,10 +1204,8 @@ static int tegra114_emc_interconnect_init(struct tegra_emc *emc)
 
        /* create External Memory Controller node */
        node = icc_node_create(TEGRA_ICC_EMC);
-       if (IS_ERR(node)) {
-               err = PTR_ERR(node);
-               goto err_msg;
-       }
+       if (IS_ERR(node))
+               return PTR_ERR(node);
 
        node->name = "External Memory Controller";
        icc_node_add(node, &emc->provider);
@@ -1235,7 +1233,6 @@ static int tegra114_emc_interconnect_init(struct tegra_emc *emc)
 
 remove_nodes:
        icc_nodes_remove(&emc->provider);
-err_msg:
        dev_err(emc->dev, "failed to initialize ICC: %d\n", err);
 
        return err;