]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: Fix memory overwrites
authorVolker Lendecke <vl@samba.org>
Mon, 10 Feb 2014 18:08:46 +0000 (10:08 -0800)
committerKarolin Seeger <kseeger@samba.org>
Fri, 14 Feb 2014 19:05:01 +0000 (20:05 +0100)
SIVAL writes 32 bit, not 16

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Back-ported-from master git commit : 9088bde059e93a84745ec2158e2e640b5bb13844

Fix bug #10415 - *** glibc detected *** /usr/sbin/smbd: free(): invalid next
size (fast).

source3/smbd/smb2_ioctl.c

index c46520a5a781d2166e8df29eb378b5454e5648f2..8d24fb59bed0647d981d21ee63de3c8efb9197ee 100644 (file)
@@ -569,8 +569,8 @@ static struct tevent_req *smbd_smb2_ioctl_send(TALLOC_CTX *mem_ctx,
 
                SIVAL(state->out_output.data, 0x00, conn->smb2.server.capabilities);
                memcpy(state->out_output.data+0x04, out_guid_blob.data, 16);
-               SIVAL(state->out_output.data, 0x14, conn->smb2.server.security_mode);
-               SIVAL(state->out_output.data, 0x16, conn->smb2.server.dialect);
+               SSVAL(state->out_output.data, 0x14, conn->smb2.server.security_mode);
+               SSVAL(state->out_output.data, 0x16, conn->smb2.server.dialect);
 
                tevent_req_done(req);
                return tevent_req_post(req, ev);