media: cx231xx: drop redundant device reference

Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c
index b64a37d1acf40e7af7f24dd99cbbf302dd996658..b75535d6abafeea003ff6f3295acfeb791d12aba 100644 (file)
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b/drivers/media/usb/cx231xx/cx231xx-cards.c
@@ -1369,8 +1369,6 @@ void cx231xx_release_resources(struct cx231xx *dev)
 
        cx231xx_unregister_media_device(dev);
 
-       usb_put_dev(dev->udev);
-
        /* Mark device as unused */
        clear_bit(dev->devno, &cx231xx_devused);
 }
@@ -1719,7 +1717,7 @@ static int cx231xx_usb_probe(struct usb_interface *interface,
                }
        } while (test_and_set_bit(nr, &cx231xx_devused));
 
-       udev = usb_get_dev(interface_to_usbdev(interface));
+       udev = interface_to_usbdev(interface);
 
        /* allocate memory for our device state and initialize it */
        dev = devm_kzalloc(&udev->dev, sizeof(*dev), GFP_KERNEL);
@@ -1915,7 +1913,6 @@ err_v4l2:
 err_media_init:
        usb_set_intfdata(interface, NULL);
 err_if:
-       usb_put_dev(udev);
        clear_bit(nr, &cx231xx_devused);
        return retval;
 }