]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: (nct7363) Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 24 Dec 2025 11:07:05 +0000 (12:07 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 31 Jan 2026 15:38:32 +0000 (07:38 -0800)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251224110702.61746-6-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/nct7363.c

index 71cef794835df7743b32eb7a183f084c876977bd..4946d59ff807b3da5cafb43876fd01f751762f6c 100644 (file)
@@ -396,7 +396,6 @@ static const struct regmap_config nct7363_regmap_config = {
 static int nct7363_probe(struct i2c_client *client)
 {
        struct device *dev = &client->dev;
-       struct device_node *child;
        struct nct7363_data *data;
        struct device *hwmon_dev;
        int ret;
@@ -409,12 +408,10 @@ static int nct7363_probe(struct i2c_client *client)
        if (IS_ERR(data->regmap))
                return PTR_ERR(data->regmap);
 
-       for_each_child_of_node(dev->of_node, child) {
+       for_each_child_of_node_scoped(dev->of_node, child) {
                ret = nct7363_present_pwm_fanin(dev, child, data);
-               if (ret) {
-                       of_node_put(child);
+               if (ret)
                        return ret;
-               }
        }
 
        /* Initialize the chip */