]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
Coverity fix
authorVictor Julien <victor@inliniac.net>
Tue, 4 Mar 2014 08:55:59 +0000 (09:55 +0100)
committerVictor Julien <victor@inliniac.net>
Tue, 4 Mar 2014 09:08:06 +0000 (10:08 +0100)
Coverity 992695, fix potential array index with negative int. Very unlikely
case at rule keyword parsing stage.

src/detect-byte-extract.c

index 9eae71eb78b1e297f8b839214da74f6bfda42e28..d5976992a4da16d85dae95b81f716237f652b99e 100644 (file)
@@ -679,6 +679,8 @@ int DetectByteExtractSetup(DetectEngineCtx *de_ctx, Signature *s, char *arg)
             sm_list = DETECT_SM_LIST_PMATCH;
         } else {
             sm_list = SigMatchListSMBelongsTo(s, prev_pm);
+            if (sm_list < 0)
+                goto error;
             if (sm_list != DETECT_SM_LIST_PMATCH)
                 s->flags |= SIG_FLAG_APPLAYER;
         }