MINOR: dns: default "hold obsolete" timeout set to 0

The "hold obsolete" timer is used to prevent HAProxy from moving a server to
an other IP or from considering the server as DOWN if the IP currently
affected to this server has not been seen for this period of time in DNS
responses.

That said, historically, HAProxy used to update servers as soon as the IP
has disappeared from the response. Current default timeout break this
historical behavior and may change HAProxy's behavior when people will
upgrade to 1.8.

This patch changes the default value to 0 to keep backward compatibility.

diff --git a/doc/configuration.txt b/doc/configuration.txt
index 8aafbe3ce635045e64a5ac4e86e98b02095efd50..66c932597a06cd3db6f76f4313e01d01a9c0ed70 100644 (file)
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -11734,7 +11734,7 @@ hold <status> <period>
                answer was in <status>. It follows the HAProxy time format.
                <period> is in milliseconds by default.
 
-  Default value is 10s for "valid" and 30s for others.
+  Default value is 10s for "valid", 0s for "obsolete" and 30s for others.
 
   Note: since the name resolution is triggered by the health checks, a new
         resolution is triggered after <period> modulo the <inter> parameter of

diff --git a/src/cfgparse.c b/src/cfgparse.c
index eebd72c114c92fb1a2060b6c3d8034a092965f56..ee249794f967c50b61905f29a64ffd0c5e7da3bb 100644 (file)
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -2169,7 +2169,7 @@ int cfg_parse_resolvers(const char *file, int linenum, char **args, int kwm)
                curr_resolvers->hold.other = 30000;
                curr_resolvers->hold.refused = 30000;
                curr_resolvers->hold.timeout = 30000;
-               curr_resolvers->hold.obsolete = 30000;
+               curr_resolvers->hold.obsolete = 0;
                /* default hold period for valid is 10s */
                curr_resolvers->hold.valid = 10000;
                curr_resolvers->timeout.retry = 1000;