r = vsnprintf(str, size, format, args);
#endif
str[size-1] = '\0';
- if (r < 0 || r >= size)
+ if (r < 0 || ((size_t)r) >= size)
return -1;
return r;
}
c->key = tor_strdup(var->name);
}
- lvalue = ((void*)options) + var->var_offset;
+ lvalue = ((char*)options) + var->var_offset;
switch(var->type) {
case CONFIG_TYPE_UINT:
SMARTLIST_FOREACH(descriptor_list, descriptor_entry_t *, d,
{
int is_live;
+ connection_t *conn;
tor_assert(d->router);
- connection_t *conn = connection_get_by_identity_digest(
+ conn = connection_get_by_identity_digest(
d->router->identity_digest, CONN_TYPE_OR);
is_live = (conn && conn->state == OR_CONN_STATE_OPEN);
smartlist_add(rr_entries, list_single_server_status(d, is_live, 1));
case RESOLVED_TYPE_ERROR_TRANSIENT:
case RESOLVED_TYPE_ERROR:
buf[1] = 24; /* length of "error resolving hostname" */
- strlcpy(buf+2, "error resolving hostname", buf-2);
+ strlcpy(buf+2, "error resolving hostname", sizeof(buf)-2);
buflen = 26;
break;
default: