]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/bridge: Fix free wrong object in sii8620_init_rcp_input_dev
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 27 Dec 2021 09:25:22 +0000 (09:25 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Apr 2022 12:14:47 +0000 (14:14 +0200)
[ Upstream commit 7c442e76c06cb1bef16a6c523487438175584eea ]

rc_dev is allocated by rc_allocate_device(), and doesn't assigned to
ctx->rc_dev before calling  rc_free_device(ctx->rc_dev).
So it should call rc_free_device(rc_dev);

Fixes: e25f1f7c94e1 ("drm/bridge/sii8620: add remote control support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211227092522.21755-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/sil-sii8620.c

index 1ea2a1b0fe375d79ca3869d71db94243f9d9f2a6..ea433bb189ca247fc93428eea731c7b1a17d9de4 100644 (file)
@@ -2122,7 +2122,7 @@ static void sii8620_init_rcp_input_dev(struct sii8620 *ctx)
        if (ret) {
                dev_err(ctx->dev, "Failed to register RC device\n");
                ctx->error = ret;
-               rc_free_device(ctx->rc_dev);
+               rc_free_device(rc_dev);
                return;
        }
        ctx->rc_dev = rc_dev;