]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
MIPS: alchemy: gpio: use new line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Apr 2025 07:25:09 +0000 (09:25 +0200)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Sun, 27 Apr 2025 07:21:21 +0000 (09:21 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/alchemy/common/gpiolib.c

index 1b16daaa86aeefcad956b480de3502fb5a955d7f..411f70ceb762ae4cedef24cd60ced92b64e31d01 100644 (file)
@@ -119,9 +119,11 @@ static int alchemy_gpic_get(struct gpio_chip *chip, unsigned int off)
        return !!au1300_gpio_get_value(off + AU1300_GPIO_BASE);
 }
 
-static void alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)
+static int alchemy_gpic_set(struct gpio_chip *chip, unsigned int off, int v)
 {
        au1300_gpio_set_value(off + AU1300_GPIO_BASE, v);
+
+       return 0;
 }
 
 static int alchemy_gpic_dir_input(struct gpio_chip *chip, unsigned int off)
@@ -145,7 +147,7 @@ static struct gpio_chip au1300_gpiochip = {
        .direction_input        = alchemy_gpic_dir_input,
        .direction_output       = alchemy_gpic_dir_output,
        .get                    = alchemy_gpic_get,
-       .set                    = alchemy_gpic_set,
+       .set_rv                 = alchemy_gpic_set,
        .to_irq                 = alchemy_gpic_gpio_to_irq,
        .base                   = AU1300_GPIO_BASE,
        .ngpio                  = AU1300_GPIO_NUM,