spi: nxp-fspi: Use reinit_completion() for repeated operations

The driver currently calls init_completion() during every spi_mem_op.
Tchnically it may work, but it's not the recommended pattern.

According to the kernel documentation: Calling init_completion() on
the same completion object twice is most likely a bug as it
re-initializes the queue to an empty queue and enqueued tasks
could get "lost" - use reinit_completion() in that case, but be
aware of other races.

So moves the initial initialization to probe function and uses
reinit_completion() for subsequent operations.

Fixes: a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Link: https://patch.msgid.link/20260304-spi-nxp-v2-2-cd7d7726a27e@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index 320b3d93df57116765a3424ec28472487a61ef56..1e36ae084dd864aa50f97d9d691710595d3da9d0 100644 (file)
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -996,7 +996,7 @@ static int nxp_fspi_do_op(struct nxp_fspi *f, const struct spi_mem_op *op)
        reg = reg | FSPI_IPRXFCR_CLR;
        fspi_writel(f, reg, base + FSPI_IPRXFCR);
 
-       init_completion(&f->c);
+       reinit_completion(&f->c);
 
        fspi_writel(f, op->addr.val, base + FSPI_IPCR0);
        /*
@@ -1365,6 +1365,7 @@ static int nxp_fspi_probe(struct platform_device *pdev)
        if (ret < 0)
                return dev_err_probe(dev, ret, "Failed to disable clock");
 
+       init_completion(&f->c);
        ret = devm_request_irq(dev, irq,
                        nxp_fspi_irq_handler, 0, pdev->name, f);
        if (ret)