firmware: meson_sm: fix to avoid potential NULL pointer dereference

[ Upstream commit f2ed165619c16577c02b703a114a1f6b52026df4 ]

of_match_device() may fail and returns a NULL pointer.

Fix this by checking the return value of of_match_device.

Fixes: 8cde3c2153e8 ("firmware: meson_sm: Rework driver as a proper platform driver")
Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/tencent_AA08AAA6C4F34D53ADCE962E188A879B8206@qq.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
index 798bcdb05d84ee067b6e7fb6c16a998ed4e9582a..9a2656d73600b510935630d9e38718582b40f2da 100644 (file)
--- a/drivers/firmware/meson/meson_sm.c
+++ b/drivers/firmware/meson/meson_sm.c
@@ -292,6 +292,8 @@ static int __init meson_sm_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        chip = of_match_device(meson_sm_ids, dev)->data;
+       if (!chip)
+               return -EINVAL;
 
        if (chip->cmd_shmem_in_base) {
                fw->sm_shmem_in_base = meson_sm_map_shmem(chip->cmd_shmem_in_base,