]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: ni_atmio: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:54 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:39 +0000 (15:49 +0200)
The "ni_atmio" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of an AT E
Series board.  Or, if the option value is zero, it can search ISA PNP
devices to look for a compatible board.  If the base address is
configured manually, it currently allows any base address to be
configured but the hardware only supports base addresses (configured by
a configuration utility and stored in nonvolatile memory) in the range
0x20 to 0xFFE0 on 32-byte boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-30-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/ni_atmio.c

index b4e759e5703fd3b4f9fcdff7c106c727c7603bff..7bc336333ace03f3de48face03afce8eb037e3dd 100644 (file)
@@ -311,7 +311,8 @@ static int ni_atmio_attach(struct comedi_device *dev,
                comedi_set_hw_dev(dev, &isapnp_dev->dev);
        }
 
-       ret = comedi_request_region(dev, iobase, 0x20);
+       ret = comedi_check_request_region(dev, iobase, 0x20,
+                                         0x20, 0xffff, 32);
        if (ret)
                return ret;