f2fs: fix to propagate error from f2fs_enable_checkpoint()

[ Upstream commit be112e7449a6e1b54aa9feac618825d154b3a5c7 ]

In order to let userspace detect such error rather than suffering
silent failure.

Fixes: 4354994f097d ("f2fs: checkpoint disabling")
Cc: stable@kernel.org
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
[ adapted error handling to use restore_gc ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 4d651a6568c64d2cbe84aca518f85a3b9a94a249..8ab7d3f9a764bc23981b94e8953d5568244e4cb6 100644 (file)
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1836,9 +1836,10 @@ restore_flag:
        return err;
 }
 
-static void f2fs_enable_checkpoint(struct f2fs_sb_info *sbi)
+static int f2fs_enable_checkpoint(struct f2fs_sb_info *sbi)
 {
        int retry = DEFAULT_RETRY_IO_COUNT;
+       int ret;
 
        /* we should flush all the data to keep data consistency */
        do {
@@ -1857,7 +1858,11 @@ static void f2fs_enable_checkpoint(struct f2fs_sb_info *sbi)
        set_sbi_flag(sbi, SBI_IS_DIRTY);
        up_write(&sbi->gc_lock);
 
-       f2fs_sync_fs(sbi->sb, 1);
+       ret = f2fs_sync_fs(sbi->sb, 1);
+       if (ret)
+               f2fs_err(sbi, "%s sync_fs failed, ret: %d", __func__, ret);
+
+       return ret;
 }
 
 static int f2fs_remount(struct super_block *sb, int *flags, char *data)
@@ -2005,7 +2010,9 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
                        if (err)
                                goto restore_gc;
                } else {
-                       f2fs_enable_checkpoint(sbi);
+                       err = f2fs_enable_checkpoint(sbi);
+                       if (err)
+                               goto restore_gc;
                }
        }
 
@@ -3933,13 +3940,12 @@ reset_checkpoint:
        /* f2fs_recover_fsync_data() cleared this already */
        clear_sbi_flag(sbi, SBI_POR_DOING);
 
-       if (test_opt(sbi, DISABLE_CHECKPOINT)) {
+       if (test_opt(sbi, DISABLE_CHECKPOINT))
                err = f2fs_disable_checkpoint(sbi);
-               if (err)
-                       goto sync_free_meta;
-       } else if (is_set_ckpt_flags(sbi, CP_DISABLED_FLAG)) {
-               f2fs_enable_checkpoint(sbi);
-       }
+       else if (is_set_ckpt_flags(sbi, CP_DISABLED_FLAG))
+               err = f2fs_enable_checkpoint(sbi);
+       if (err)
+               goto sync_free_meta;
 
        /*
         * If filesystem is not mounted as read-only then