add a couple of FIXMEs to broken code

Signed-off-by: Lennart Poettering <lennart@poettering.net>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
Signed-off-by: Dhaval Giani <dhaval.giani@gmail.com>

diff --git a/src/api.c b/src/api.c
index 365ab21602689fcbe74b31571e312a11caeb8f53..cb708d7957e46963c0cc57ba56d6d13bc2b014a1 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -498,6 +498,9 @@ static int cgroup_parse_rules(bool cache, uid_t muid,
                                        matched = false;
                                        continue;
                                }
+
+                                /* FIXME: basename() modifies the string and really shouldn't! */
+
                                if (strcmp(mprocname, procname) &&
                                        strcmp(basename(mprocname), procname)) {
                                        uid = CGRULE_INVALID;
@@ -827,6 +830,9 @@ static char *cg_build_path_locked(const char *name, char *path, const char *type
                        if (name) {
                                char *tmp;
                                tmp = strdup(path);
+
+                                /* FIXME: missing OOM check here! */
+
                                sprintf(path, "%s%s/", tmp, name);
                                free(tmp);
                        }
@@ -2179,6 +2185,9 @@ static struct cgroup_rule *cgroup_find_matching_rule(uid_t uid,
                        break;
                if (!strcmp(ret->procname, procname))
                        break;
+
+                /* FIXME: basename() modifies the string and really shouldn't! */
+
                if (!strcmp(ret->procname, basename(procname)))
                        /* Check a rule of basename. */
                        break;