]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
QUIC BIO Poll Descriptors: simplify custom interface
authorHugo Landau <hlandau@openssl.org>
Mon, 9 Jan 2023 11:20:08 +0000 (11:20 +0000)
committerHugo Landau <hlandau@openssl.org>
Fri, 13 Jan 2023 13:20:36 +0000 (13:20 +0000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19703)

doc/man3/BIO_get_rpoll_descriptor.pod
include/openssl/bio.h.in

index 36d6b64ff58ef49297189bba99e34a981683c028..423ad1cdda4359ed63dd4ab56ce63dcce4d4da6e 100644 (file)
@@ -13,10 +13,7 @@ can be used to determine when a BIO object can next be read or written
      int type;
      union {
          int     fd;
-         union {
-             void        *ptr;
-             uint64_t    u64;
-         } custom[BIO_POLL_DESCRIPTOR_NUM_CUSTOM];
+         void    *custom;
      } value;
  } BIO_POLL_DESCRIPTOR;
 
@@ -75,9 +72,8 @@ complete a BIO_write() operation.
 
 Type values beginning with this value (inclusive) are reserved for application
 allocation for custom poll descriptor types. The field I<value.custom> in the
-B<BIO_POLL_DESCRIPTOR> is an array of length B<BIO_POLL_DESCRIPTOR_NUM_CUSTOM>.
-Each entry in this array can store a void pointer or a B<uint64_t> and can be
-used by the application arbitrarily.
+B<BIO_POLL_DESCRIPTOR> is an opaque pointer which can be used by the application
+arbitrarily.
 
 =back
 
index dbb65f50e488e670f7dfb5cdf6c2bb31fc3f97dd..037f1ed3fffb8c3d3f7534cd158beed90a9c21d5 100644 (file)
@@ -383,16 +383,12 @@ typedef struct bio_mmsg_cb_args_st {
 #define BIO_POLL_DESCRIPTOR_TYPE_NONE       0
 #define BIO_POLL_DESCRIPTOR_TYPE_SOCK_FD    1
 #define BIO_POLL_DESCRIPTOR_CUSTOM_START    8192
-#define BIO_POLL_DESCRIPTOR_NUM_CUSTOM      4
 
 typedef struct bio_poll_descriptor_st {
     int type;
     union {
         int     fd;
-        union {
-            void        *ptr;
-            uint64_t    u64;
-        } custom[BIO_POLL_DESCRIPTOR_NUM_CUSTOM];
+        void    *custom;
     } value;
 } BIO_POLL_DESCRIPTOR;