BGP: Moved the suppressed and stale flags to pflags

diff --git a/nest/route.h b/nest/route.h
index ac59ed84b1b694cb4d1539a37a50be600fc0cb4c..cb2c686f590bbbd9ce2a216f255cee9cd4e63bb3 100644 (file)
--- a/nest/route.h
+++ b/nest/route.h
@@ -236,12 +236,6 @@ typedef struct rte {
       u32 router_id;                   /* Router that originated this route */
     } ospf;
 #endif
-#ifdef CONFIG_BGP
-    struct {
-      u8 suppressed;                   /* Used for deterministic MED comparison */
-      s8 stale;                                /* Route is LLGR_STALE, -1 if unknown */
-    } bgp;
-#endif
 #ifdef CONFIG_BABEL
     struct {
       u16 seqno;                       /* Babel seqno */

diff --git a/proto/bgp/attrs.c b/proto/bgp/attrs.c
index 8eb7f88133bef3bf4390973b309eddc6016961e8..59a82f95d2d204fb0e1da9a4c140109e86bdfb25 100644 (file)
--- a/proto/bgp/attrs.c
+++ b/proto/bgp/attrs.c
@@ -1850,14 +1850,24 @@ bgp_get_neighbor(rte *r)
 static inline int
 rte_stale(rte *r)
 {
-  if (r->u.bgp.stale < 0)
+  if (r->pflags & BGP_REF_STALE)
+    return 1;
+
+  if (r->pflags & BGP_REF_NOT_STALE)
+    return 0;
+
+  /* If staleness is unknown, compute and cache it */
+  eattr *a = ea_find(r->attrs->eattrs, EA_CODE(PROTOCOL_BGP, BA_COMMUNITY));
+  if (a && int_set_contains(a->u.ptr, BGP_COMM_LLGR_STALE))
   {
-    /* If staleness is unknown, compute and cache it */
-    eattr *a = ea_find(r->attrs->eattrs, EA_CODE(PROTOCOL_BGP, BA_COMMUNITY));
-    r->u.bgp.stale = a && int_set_contains(a->u.ptr, BGP_COMM_LLGR_STALE);
+    r->pflags |= BGP_REF_STALE;
+    return 1;
+  }
+  else
+  {
+    r->pflags |= BGP_REF_NOT_STALE;
+    return 0;
   }
-
-  return r->u.bgp.stale;
 }
 
 int
@@ -1869,8 +1879,8 @@ bgp_rte_better(rte *new, rte *old)
   u32 n, o;
 
   /* Skip suppressed routes (see bgp_rte_recalculate()) */
-  n = new->u.bgp.suppressed;
-  o = old->u.bgp.suppressed;
+  n = new->pflags & BGP_REF_SUPPRESSED;
+  o = old->pflags & BGP_REF_SUPPRESSED;
   if (n > o)
     return 0;
   if (n < o)
@@ -2014,17 +2024,14 @@ bgp_rte_mergable(rte *pri, rte *sec)
   u32 p, s;
 
   /* Skip suppressed routes (see bgp_rte_recalculate()) */
-  if (pri->u.bgp.suppressed != sec->u.bgp.suppressed)
+  /* LLGR draft - depreference stale routes */
+  if (pri->pflags != sec->pflags)
     return 0;
 
   /* RFC 4271 9.1.2.1. Route resolvability test */
   if (rte_resolvable(pri) != rte_resolvable(sec))
     return 0;
 
-  /* LLGR draft - depreference stale routes */
-  if (rte_stale(pri) != rte_stale(sec))
-    return 0;
-
   /* Start with local preferences */
   x = ea_find(pri->attrs->eattrs, EA_CODE(PROTOCOL_BGP, BA_LOCAL_PREF));
   y = ea_find(sec->attrs->eattrs, EA_CODE(PROTOCOL_BGP, BA_LOCAL_PREF));
@@ -2104,7 +2111,7 @@ bgp_rte_recalculate(rtable *table, net *net, rte *new, rte *old, rte *old_best)
   rte *key = new ? new : old;
   u32 lpref = key->attrs->pref;
   u32 lasn = bgp_get_neighbor(key);
-  int old_suppressed = old ? old->u.bgp.suppressed : 0;
+  int old_suppressed = old ? !!(old->pflags & BGP_REF_SUPPRESSED) : 0;
 
   /*
    * Proper RFC 4271 path selection is a bit complicated, it cannot be
@@ -2156,11 +2163,11 @@ bgp_rte_recalculate(rtable *table, net *net, rte *new, rte *old, rte *old_best)
    */
 
   if (new)
-    new->u.bgp.suppressed = 1;
+    new->pflags |= BGP_REF_SUPPRESSED;
 
   if (old)
   {
-    old->u.bgp.suppressed = 1;
+    old->pflags |= BGP_REF_SUPPRESSED;
 
     /* The fast case - replace not best with worse (or remove not best) */
     if (old_suppressed && !(new && bgp_rte_better(new, old)))
@@ -2172,7 +2179,7 @@ bgp_rte_recalculate(rtable *table, net *net, rte *new, rte *old, rte *old_best)
   for (s=net->routes; rte_is_valid(s); s=s->next)
     if (use_deterministic_med(s) && same_group(s, lpref, lasn))
     {
-      s->u.bgp.suppressed = 1;
+      s->pflags |= BGP_REF_SUPPRESSED;
       if (!r || bgp_rte_better(s, r))
        r = s;
     }
@@ -2183,16 +2190,16 @@ bgp_rte_recalculate(rtable *table, net *net, rte *new, rte *old, rte *old_best)
 
   /* Found if new is mergable with best-in-group */
   if (new && (new != r) && bgp_rte_mergable(r, new))
-    new->u.bgp.suppressed = 0;
+    new->pflags &= ~BGP_REF_SUPPRESSED;
 
   /* Found all existing routes mergable with best-in-group */
   for (s=net->routes; rte_is_valid(s); s=s->next)
     if (use_deterministic_med(s) && same_group(s, lpref, lasn))
       if ((s != r) && bgp_rte_mergable(r, s))
-       s->u.bgp.suppressed = 0;
+       s->pflags &= ~BGP_REF_SUPPRESSED;
 
   /* Found best-in-group */
-  r->u.bgp.suppressed = 0;
+  r->pflags &= ~BGP_REF_SUPPRESSED;
 
   /*
    * There are generally two reasons why we have to force
@@ -2240,7 +2247,7 @@ bgp_rte_modify_stale(struct rte *r, struct linpool *pool)
   r = rte_cow_rta(r, pool);
   bgp_set_attr_ptr(&(r->attrs->eattrs), pool, BA_COMMUNITY, flags,
                   int_set_add(pool, ad, BGP_COMM_LLGR_STALE));
-  r->u.bgp.stale = 1;
+  r->pflags |= BGP_REF_STALE;
 
   return r;
 }
@@ -2327,7 +2334,7 @@ bgp_get_route_info(rte *e, byte *buf)
 
   buf += bsprintf(buf, " (%d", e->attrs->pref);
 
-  if (e->u.bgp.suppressed)
+  if (e->pflags & BGP_REF_SUPPRESSED)
     buf += bsprintf(buf, "-");
 
   if (rte_stale(e))

diff --git a/proto/bgp/bgp.h b/proto/bgp/bgp.h
index 455f04f9ed9d763843ef819193d292a01516aa85..baa6cf32e4abd4af539f4c6eae44480677949c93 100644 (file)
--- a/proto/bgp/bgp.h
+++ b/proto/bgp/bgp.h
@@ -200,6 +200,10 @@ struct bgp_channel_config {
 
 #define BGP_BFD_GRACEFUL       2       /* BFD down triggers graceful restart */
 
+/* rte->pflags */
+#define BGP_REF_SUPPRESSED     0x1     /* Used for deterministic MED comparison */
+#define BGP_REF_STALE          0x2     /* Route is LLGR_STATE */
+#define BGP_REF_NOT_STALE      0x4     /* Route is NOT LLGR_STATE */
 
 struct bgp_af_caps {
   u32 afi;

diff --git a/proto/bgp/packets.c b/proto/bgp/packets.c
index c44e16765bf33b5ee9097a7052e9529d73f5e636..8e591022c12d2e0872d78996d7b328fdc8a7534c 100644 (file)
--- a/proto/bgp/packets.c
+++ b/proto/bgp/packets.c
@@ -1321,7 +1321,6 @@ bgp_rte_update(struct bgp_parse_state *s, net_addr *n, u32 path_id, rta *a0)
 
   rte e0 = {
     .attrs = rta_clone(s->cached_rta),
-    .u.bgp.stale = -1,
   };
 
   rte_update(&(s->channel->c), n, &e0);

diff --git a/proto/pipe/pipe.c b/proto/pipe/pipe.c
index 284eea554d7001d68b32fa3c7b4e3506bd5c7dec..277d1cf9896764920302945384e5d1bc1d65fa2e 100644 (file)
--- a/proto/pipe/pipe.c
+++ b/proto/pipe/pipe.c
@@ -41,6 +41,10 @@
 #include "filter/filter.h"
 #include "lib/string.h"
 
+#ifdef CONFIG_BGP
+#include "proto/bgp/bgp.h"
+#endif
+
 #include "pipe.h"
 
 static void
@@ -81,7 +85,7 @@ pipe_rt_notify(struct proto *P, struct channel *src_ch, net *n, rte *new, rte *o
 #ifdef CONFIG_BGP
       /* Hack to cleanup cached value */
       if (e->attrs->src->proto->proto == &proto_bgp)
-       e->u.bgp.stale = -1;
+       e->pflags &= ~(BGP_REF_STALE | BGP_REF_NOT_STALE);
 #endif
 
       src = a->src;