]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests/landlock: Properly close a file descriptor
authorGünther Noack <gnoack3000@gmail.com>
Thu, 1 Jan 2026 13:40:58 +0000 (14:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jan 2026 10:18:41 +0000 (11:18 +0100)
[ Upstream commit 15e8d739fda1084d81f7d3813e9600eba6e0f134 ]

Add a missing close(srv_fd) call, and use EXPECT_EQ() to check the
result.

Signed-off-by: Günther Noack <gnoack3000@gmail.com>
Fixes: f83d51a5bdfe ("selftests/landlock: Check IOCTL restrictions for named UNIX domain sockets")
Link: https://lore.kernel.org/r/20260101134102.25938-2-gnoack3000@gmail.com
[mic: Use EXPECT_EQ() and update commit message]
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/landlock/fs_test.c

index 01bb59938dd7a6b10b820c55297bf0d5d9dafc65..c781014e6a5c655b984a8f5db73e95b2b76220d0 100644 (file)
@@ -4189,7 +4189,8 @@ TEST_F_FORK(layout1, named_unix_domain_socket_ioctl)
        /* FIONREAD and other IOCTLs should not be forbidden. */
        EXPECT_EQ(0, test_fionread_ioctl(cli_fd));
 
-       ASSERT_EQ(0, close(cli_fd));
+       EXPECT_EQ(0, close(cli_fd));
+       EXPECT_EQ(0, close(srv_fd));
 }
 
 /* clang-format off */