491. [bug] nsupdate would segfault when sending certain

			prerequisites with empty RDATA. [RT #356]

diff --git a/CHANGES b/CHANGES
index 914672fd733a39993141b365f663d428eed0048a..552749a6d92f1620afbc6ffcf4af8595b88ace0a 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+ 491.  [bug]           nsupdate would segfault when sending certain
+                       prerequisites with empty RDATA. [RT #356]
+
  488.  [bug]           Locks weren't properly destroyed in some cases.
 
  476.  [bug]           A zone could expire while a zone transfer was in

diff --git a/lib/dns/rdata.c b/lib/dns/rdata.c
index 417a1caae63228cdd69b7adc890a5cb0816905c4..23f244ca84e04569aba2164973a1969ec4d7ddae 100644 (file)
--- a/lib/dns/rdata.c
+++ b/lib/dns/rdata.c
@@ -15,7 +15,7 @@
  * SOFTWARE.
  */
 
-/* $Id: rdata.c,v 1.101.2.3 2000/09/19 02:02:23 bwelling Exp $ */
+/* $Id: rdata.c,v 1.101.2.4 2000/09/26 21:40:55 bwelling Exp $ */
 
 #include <config.h>
 #include <ctype.h>
@@ -443,6 +443,12 @@ dns_rdata_towire(dns_rdata_t *rdata, dns_compress_t *cctx,
 
        REQUIRE(rdata != NULL);
 
+       /*
+        * Some DynDNS meta-RRs have empty rdata.
+        */
+       if (rdata->length == 0)
+               return (ISC_R_SUCCESS);
+
        st = *target;
 
        TOWIRESWITCH