]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ARM: orion/gpio: use new line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Apr 2025 07:09:18 +0000 (09:09 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 9 Apr 2025 08:25:25 +0000 (10:25 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20250407-gpiochip-set-rv-arm-v1-1-9e4a914c7fd4@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
arch/arm/plat-orion/gpio.c

index 595e9cb33c1d2df0d43dfe8fbbdfe307e41b62b9..766036fdd7922659e93acfd398e3e6a7dab8890c 100644 (file)
@@ -211,7 +211,7 @@ orion_gpio_direction_output(struct gpio_chip *chip, unsigned pin, int value)
        return 0;
 }
 
-static void orion_gpio_set(struct gpio_chip *chip, unsigned pin, int value)
+static int orion_gpio_set(struct gpio_chip *chip, unsigned int pin, int value)
 {
        struct orion_gpio_chip *ochip = gpiochip_get_data(chip);
        unsigned long flags;
@@ -219,6 +219,8 @@ static void orion_gpio_set(struct gpio_chip *chip, unsigned pin, int value)
        spin_lock_irqsave(&ochip->lock, flags);
        __set_level(ochip, pin, value);
        spin_unlock_irqrestore(&ochip->lock, flags);
+
+       return 0;
 }
 
 static int orion_gpio_to_irq(struct gpio_chip *chip, unsigned pin)
@@ -540,7 +542,7 @@ void __init orion_gpio_init(int gpio_base, int ngpio,
        ochip->chip.direction_input = orion_gpio_direction_input;
        ochip->chip.get = orion_gpio_get;
        ochip->chip.direction_output = orion_gpio_direction_output;
-       ochip->chip.set = orion_gpio_set;
+       ochip->chip.set_rv = orion_gpio_set;
        ochip->chip.to_irq = orion_gpio_to_irq;
        ochip->chip.base = gpio_base;
        ochip->chip.ngpio = ngpio;