]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Tweak EOF handling of streams
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 9 Apr 2013 12:24:02 +0000 (13:24 +0100)
committerCole Robinson <crobinso@redhat.com>
Tue, 11 Jun 2013 22:28:23 +0000 (18:28 -0400)
Typically when you get EOF on a stream, poll will return
POLLIN|POLLHUP at the same time. Thus when we deal with
stream reads, if we see EOF during the read, we can then
clear the VIR_STREAM_EVENT_HANGUP & VIR_STREAM_EVENT_ERROR
event bits.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit e7b0382945c9bf043f06ee4dd760c2051d63d0f0)

daemon/stream.c

index 58c53a9c536986432226e34eed6af43d07e62359..43489eb38ecc6f161cbfe4b9825124107211a668 100644 (file)
@@ -148,6 +148,14 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque)
             virNetServerClientClose(client);
             goto cleanup;
         }
+        /* If we detected EOF during read processing,
+         * then clear hangup/error conditions, since
+         * we want the client to see the EOF message
+         * we just sent them
+         */
+        if (stream->recvEOF)
+            events = events & ~(VIR_STREAM_EVENT_HANGUP |
+                                VIR_STREAM_EVENT_ERROR);
     }
 
     /* If we have a completion/abort message, always process it */