]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
can: kvaser_pciefd: Add intermediate variable for device struct in probe()
authorJimmy Assarsson <extja@kvaser.com>
Fri, 25 Jul 2025 12:32:23 +0000 (14:32 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 25 Jul 2025 15:53:49 +0000 (17:53 +0200)
Add intermediate variable, for readability and to simplify future patches.

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
Link: https://patch.msgid.link/20250725123230.8-4-extja@kvaser.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/kvaser_pciefd.c

index ed1ea8a9a6d28667d3c3019fd82e219470a5742b..4bdb1132ecf9430e46fa267dd5a6f5ac2134686d 100644 (file)
@@ -1813,10 +1813,11 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev,
                               const struct pci_device_id *id)
 {
        int ret;
+       struct device *dev = &pdev->dev;
        struct kvaser_pciefd *pcie;
        const struct kvaser_pciefd_irq_mask *irq_mask;
 
-       pcie = devm_kzalloc(&pdev->dev, sizeof(*pcie), GFP_KERNEL);
+       pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
        if (!pcie)
                return -ENOMEM;
 
@@ -1855,7 +1856,7 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev,
 
        ret = pci_alloc_irq_vectors(pcie->pci, 1, 1, PCI_IRQ_INTX | PCI_IRQ_MSI);
        if (ret < 0) {
-               dev_err(&pcie->pci->dev, "Failed to allocate IRQ vectors.\n");
+               dev_err(dev, "Failed to allocate IRQ vectors.\n");
                goto err_teardown_can_ctrls;
        }
 
@@ -1868,7 +1869,7 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev,
        ret = request_irq(pcie->pci->irq, kvaser_pciefd_irq_handler,
                          IRQF_SHARED, KVASER_PCIEFD_DRV_NAME, pcie);
        if (ret) {
-               dev_err(&pcie->pci->dev, "Failed to request IRQ %d\n", pcie->pci->irq);
+               dev_err(dev, "Failed to request IRQ %d\n", pcie->pci->irq);
                goto err_pci_free_irq_vectors;
        }
        iowrite32(KVASER_PCIEFD_SRB_IRQ_DPD0 | KVASER_PCIEFD_SRB_IRQ_DPD1,