]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clocksource/drivers/jcore: Use request_percpu_irq()
authorUros Bizjak <ubizjak@gmail.com>
Mon, 2 Sep 2024 10:48:04 +0000 (12:48 +0200)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Fri, 6 Sep 2024 12:49:21 +0000 (14:49 +0200)
Use request_percpu_irq() instead of request_irq() to solve
the following sparse warning:

jcore-pit.c:173:40: warning: incorrect type in argument 5 (different address spaces)
jcore-pit.c:173:40:    expected void *dev
jcore-pit.c:173:40:    got struct jcore_pit [noderef] __percpu *static [assigned] [toplevel] jcore_pit_percpu

Compile tested only.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Rich Felker <dalias@libc.org>
Link: https://lore.kernel.org/r/20240902104810.21080-1-ubizjak@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/jcore-pit.c

index a4a991101fa3160f72cabcc6f10f83d51111a1e8..a3fe98cd38382028acb1a32b85e087d655ce83f0 100644 (file)
@@ -120,7 +120,7 @@ static int jcore_pit_local_init(unsigned cpu)
 
 static irqreturn_t jcore_timer_interrupt(int irq, void *dev_id)
 {
-       struct jcore_pit *pit = this_cpu_ptr(dev_id);
+       struct jcore_pit *pit = dev_id;
 
        if (clockevent_state_oneshot(&pit->ced))
                jcore_pit_disable(pit);
@@ -168,9 +168,8 @@ static int __init jcore_pit_init(struct device_node *node)
                return -ENOMEM;
        }
 
-       err = request_irq(pit_irq, jcore_timer_interrupt,
-                         IRQF_TIMER | IRQF_PERCPU,
-                         "jcore_pit", jcore_pit_percpu);
+       err = request_percpu_irq(pit_irq, jcore_timer_interrupt,
+                                "jcore_pit", jcore_pit_percpu);
        if (err) {
                pr_err("pit irq request failed: %d\n", err);
                free_percpu(jcore_pit_percpu);