]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dmaengine: fsl_raid: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 9 Jan 2026 16:57:54 +0000 (17:57 +0100)
committerRob Herring (Arm) <robh@kernel.org>
Wed, 4 Feb 2026 02:58:13 +0000 (20:58 -0600)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260109-of-for-each-compatible-scoped-v3-10-c22fa2c0749a@oss.qualcomm.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/dma/fsl_raid.c

index 6aa97e258a557c9139bccae91622c1d3211056bc..6e6d7e0e475e31722ce0ad9e58b9aef8d95c56cd 100644 (file)
@@ -746,7 +746,6 @@ err_free:
 static int fsl_re_probe(struct platform_device *ofdev)
 {
        struct fsl_re_drv_private *re_priv;
-       struct device_node *np;
        struct device_node *child;
        u32 off;
        u8 ridx = 0;
@@ -823,11 +822,10 @@ static int fsl_re_probe(struct platform_device *ofdev)
        dev_set_drvdata(dev, re_priv);
 
        /* Parse Device tree to find out the total number of JQs present */
-       for_each_compatible_node(np, NULL, "fsl,raideng-v1.0-job-queue") {
+       for_each_compatible_node_scoped(np, NULL, "fsl,raideng-v1.0-job-queue") {
                rc = of_property_read_u32(np, "reg", &off);
                if (rc) {
                        dev_err(dev, "Reg property not found in JQ node\n");
-                       of_node_put(np);
                        return -ENODEV;
                }
                /* Find out the Job Rings present under each JQ */