]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
serial: 8250_ce4100: Fix CONFIG_SERIAL_8250=n build
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 16 Jul 2025 14:23:29 +0000 (17:23 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Jul 2025 15:38:08 +0000 (17:38 +0200)
On i386, when

  CONFIG_X86_INTEL_CE=y
  # CONFIG_SERIAL_8250 is not set

it will try to compile the driver and use the stub simultaneously.
This breaks the build. Fix it by making sure that the driver
compiles only when CONFIG_SERIAL_8250 is also enabled.

On top of that ensure that CONFIG_SERIAL_8250 is actually set to 'y'
and not 'm' as the later makes no sense for this platform. The hook
may only be applied during early boot.

Fixes: acc902de05b2 ("serial: 8250: Move CE4100 quirks to a module under 8250 driver")
Fixes: 5ec6960f6f0c ("ce4100: Add errata fixes for UART on CE4100")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/r/cdf4ee46-7bf8-4379-9245-fed9db72e7e8@infradead.org
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20250716142412.1667927-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/Makefile

index e61dc3f4ca50eb4fcc65c28ff9ad4b2540399231..513a0941c284f8a1fe933f19ede6fcd907264fda 100644 (file)
@@ -24,7 +24,9 @@ obj-$(CONFIG_SERIAL_8250_ASPEED_VUART)        += 8250_aspeed_vuart.o
 obj-$(CONFIG_SERIAL_8250_BCM2835AUX)   += 8250_bcm2835aux.o
 obj-$(CONFIG_SERIAL_8250_BCM7271)      += 8250_bcm7271.o
 obj-$(CONFIG_SERIAL_8250_BOCA)         += 8250_boca.o
+ifeq ($(CONFIG_SERIAL_8250),y)
 obj-$(CONFIG_X86_INTEL_CE)             += 8250_ce4100.o
+endif
 obj-$(CONFIG_SERIAL_8250_DFL)          += 8250_dfl.o
 obj-$(CONFIG_SERIAL_8250_DW)           += 8250_dw.o
 obj-$(CONFIG_SERIAL_8250_EM)           += 8250_em.o