]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
rnbd-srv: Zero the rsp buffer before using it
authorMd Haris Iqbal <haris.iqbal@ionos.com>
Fri, 5 Dec 2025 12:47:33 +0000 (13:47 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 6 Jan 2026 12:28:10 +0000 (05:28 -0700)
Before using the data buffer to send back the response message, zero it
completely. This prevents any stray bytes to be picked up by the client
side when there the message is exchanged between different protocol
versions.

Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rnbd/rnbd-srv.c

index 9b3fdc202e1521be9e146ba4ac755a5badfc00b5..7eeb321d61402f3a64f22ef5fe2312fb9ac24ff6 100644 (file)
@@ -551,6 +551,8 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
 {
        struct block_device *bdev = file_bdev(sess_dev->bdev_file);
 
+       memset(rsp, 0, sizeof(*rsp));
+
        rsp->hdr.type = cpu_to_le16(RNBD_MSG_OPEN_RSP);
        rsp->device_id = cpu_to_le32(sess_dev->device_id);
        rsp->nsectors = cpu_to_le64(bdev_nr_sectors(bdev));
@@ -657,6 +659,7 @@ static void process_msg_sess_info(struct rnbd_srv_session *srv_sess,
 
        trace_process_msg_sess_info(srv_sess, sess_info_msg);
 
+       memset(rsp, 0, sizeof(*rsp));
        rsp->hdr.type = cpu_to_le16(RNBD_MSG_SESS_INFO_RSP);
        rsp->ver = srv_sess->ver;
 }