nl80211: Fix potential NULL pointer dereference in set_ap()

In the code review, it was found that param->freq is accessed without
NULL check in wpa_driver_nl80211_set_ap(), while in other sections of
the code, freq is accessed only after NULL validation. This situation
could result in a segmentation fault at least in theory.

Add a NULL check for freq before accessing it to be consistent with the
other uses.

Fixes: 0c6c948047de ("nl80211: Support setting up an AP on a specified link")
Signed-off-by: Karthikeyan Kathirvel <quic_kathirve@quicinc.com>

diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index 92aaf2c3402b30ae49991ce85a1a575eaa39fa1b..be077db9130b2bb2dde13737a895fc225f863331 100644 (file)
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -5109,8 +5109,9 @@ static int wpa_driver_nl80211_set_ap(void *priv,
                     nl80211_put_freq_params(msg, params->freq) < 0))
                        goto fail;
 
-               nl80211_link_set_freq(bss, params->mld_link_id,
-                                     params->freq->freq);
+               if (params->freq)
+                       nl80211_link_set_freq(bss, params->mld_link_id,
+                                             params->freq->freq);
        }
 
        if (params->proberesp && params->proberesp_len) {