]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: mtu3: fix failed runtime suspend in host only mode
authorChunfeng Yun <chunfeng.yun@mediatek.com>
Thu, 29 Sep 2022 06:44:59 +0000 (14:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:00 +0000 (09:58 +0200)
[ Upstream commit 1c703e29da5efac6180e4c189029fa34b7e48e97 ]

When the dr_mode is "host", after the host enter runtime suspend,
the mtu3 can't do it, because the mtu3's device wakeup function is
not enabled, instead it's enabled in gadget init function, to fix
the issue, init wakeup early in mtu3's probe()

Fixes: 6b587394c65c ("usb: mtu3: support suspend/resume for dual-role mode")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reported-by: Tianping Fang <tianping.fang@mediatek.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/20220929064459.32522-1-chunfeng.yun@mediatek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/mtu3/mtu3_core.c
drivers/usb/mtu3/mtu3_plat.c

index c4a2c37abf628117e5f61d0f868ceb383bcf2698..3ea5145a842b19a36bc032e6b21ed668ea0fe633 100644 (file)
@@ -971,8 +971,6 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb)
                goto irq_err;
        }
 
-       device_init_wakeup(dev, true);
-
        /* power down device IP for power saving by default */
        mtu3_stop(mtu);
 
index 4309ed939178a84a3ae949fe896c66db97e98396..845b25320fd28501834b572ef498646f9bd87b4a 100644 (file)
@@ -332,6 +332,8 @@ static int mtu3_probe(struct platform_device *pdev)
        pm_runtime_enable(dev);
        pm_runtime_get_sync(dev);
 
+       device_init_wakeup(dev, true);
+
        ret = ssusb_rscs_init(ssusb);
        if (ret)
                goto comm_init_err;