don't compare unsigned values as negative ones

Instead, check that the result is larger than its parts.

Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>

diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index 084b5563ef2bc2c18f1af615b520dca38d3d40d2..fe71e9aa454ce747b9912e6da3a471eac8171314 100644 (file)
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -1645,12 +1645,13 @@ int setproctitle(char *title)
                        env_start = env_end;
                }
 
+               arg_end = arg_start + len;
+
                /* check overflow */
-               if (arg_start + len < 0) {
+               if (arg_end < len || arg_end < arg_start) {
                        return -1;
                }
 
-               arg_end = arg_start + len;
        }
 
        strcpy((char*)arg_start, title);