selftests/bpf: Replace strcpy() calls with strscpy()

strcpy() does not perform bounds checking and is considered deprecated
[1]. Replace strcpy() calls with strscpy() defined in bpf_util.h.

[1] https://docs.kernel.org/process/deprecated.html#strcpy

Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Link: https://lore.kernel.org/r/20260223190736.649171-3-ihor.solodrai@linux.dev
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

diff --git a/tools/testing/selftests/bpf/network_helpers.c b/tools/testing/selftests/bpf/network_helpers.c
index 0a6a5561bed39997a75e68de684b18678680f45c..5374b7e16d53645a7a2dffff9fc4d4ec68dfd2d6 100644 (file)
--- a/tools/testing/selftests/bpf/network_helpers.c
+++ b/tools/testing/selftests/bpf/network_helpers.c
@@ -432,7 +432,7 @@ int make_sockaddr(int family, const char *addr_str, __u16 port,
                memset(addr, 0, sizeof(*sun));
                sun->sun_family = family;
                sun->sun_path[0] = 0;
-               strcpy(sun->sun_path + 1, addr_str);
+               strscpy(sun->sun_path + 1, addr_str, sizeof(sun->sun_path) - 1);
                if (len)
                        *len = offsetof(struct sockaddr_un, sun_path) + 1 + strlen(addr_str);
                return 0;

diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c b/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
index b7d1b52309d0f0ba8e42d28de1eaabcb9374b76e..f829b6f09bc9d3de48b7419c48408d4769dcd024 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
+++ b/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
@@ -281,7 +281,7 @@ static void test_dctcp_fallback(void)
        dctcp_skel = bpf_dctcp__open();
        if (!ASSERT_OK_PTR(dctcp_skel, "dctcp_skel"))
                return;
-       strcpy(dctcp_skel->rodata->fallback_cc, "cubic");
+       strscpy(dctcp_skel->rodata->fallback_cc, "cubic");
        if (!ASSERT_OK(bpf_dctcp__load(dctcp_skel), "bpf_dctcp__load"))
                goto done;
 

diff --git a/tools/testing/selftests/bpf/prog_tests/setget_sockopt.c b/tools/testing/selftests/bpf/prog_tests/setget_sockopt.c
index e4dac529d4247d3053185a260fed342b63563963..77fe1bfb7504e0d9c48e4ded153478c4ceeeb406 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/setget_sockopt.c
+++ b/tools/testing/selftests/bpf/prog_tests/setget_sockopt.c
@@ -212,7 +212,7 @@ void test_setget_sockopt(void)
        if (!ASSERT_OK_PTR(skel, "open skel"))
                goto done;
 
-       strcpy(skel->rodata->veth, "binddevtest1");
+       strscpy(skel->rodata->veth, "binddevtest1");
        skel->rodata->veth_ifindex = if_nametoindex("binddevtest1");
        if (!ASSERT_GT(skel->rodata->veth_ifindex, 0, "if_nametoindex"))
                goto done;

diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c b/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
index ba6b3ec1156ae8729e09739319b7ad0955002b88..53637431ec5de3b78ed41813ff1f42897e645158 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
@@ -142,7 +142,7 @@ static int getsetsockopt(void)
 
        /* TCP_CONGESTION can extend the string */
 
-       strcpy(buf.cc, "nv");
+       strscpy(buf.cc, "nv");
        err = setsockopt(fd, SOL_TCP, TCP_CONGESTION, &buf, strlen("nv"));
        if (err) {
                log_err("Failed to call setsockopt(TCP_CONGESTION)");

diff --git a/tools/testing/selftests/bpf/prog_tests/test_veristat.c b/tools/testing/selftests/bpf/prog_tests/test_veristat.c
index b38c16b4247f77eca4a43275d9dd20a3de934919..9aff08ac55c07dc08c9d041d802a6d1f8f3d1847 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/test_veristat.c
+++ b/tools/testing/selftests/bpf/prog_tests/test_veristat.c
@@ -24,9 +24,9 @@ static struct fixture *init_fixture(void)
 
        /* for no_alu32 and cpuv4 veristat is in parent folder */
        if (access("./veristat", F_OK) == 0)
-               strcpy(fix->veristat, "./veristat");
+               strscpy(fix->veristat, "./veristat");
        else if (access("../veristat", F_OK) == 0)
-               strcpy(fix->veristat, "../veristat");
+               strscpy(fix->veristat, "../veristat");
        else
                PRINT_FAIL("Can't find veristat binary");
 

diff --git a/tools/testing/selftests/bpf/xdp_features.c b/tools/testing/selftests/bpf/xdp_features.c
index 595c79141cf327c32cc01dcf49b040de7ffce3d3..a27ed663967c42949a638cd9181223819f16583d 100644 (file)
--- a/tools/testing/selftests/bpf/xdp_features.c
+++ b/tools/testing/selftests/bpf/xdp_features.c
@@ -16,6 +16,7 @@
 
 #include <network_helpers.h>
 
+#include "bpf_util.h"
 #include "xdp_features.skel.h"
 #include "xdp_features.h"
 
@@ -212,7 +213,7 @@ static void set_env_default(void)
        env.feature.drv_feature = NETDEV_XDP_ACT_NDO_XMIT;
        env.feature.action = -EINVAL;
        env.ifindex = -ENODEV;
-       strcpy(env.ifname, "unknown");
+       strscpy(env.ifname, "unknown");
        make_sockaddr(AF_INET6, "::ffff:127.0.0.1", DUT_CTRL_PORT,
                      &env.dut_ctrl_addr, NULL);
        make_sockaddr(AF_INET6, "::ffff:127.0.0.1", DUT_ECHO_PORT,