]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virCommandAddArg: Don't abort on invalid input
authorPeter Krempa <pkrempa@redhat.com>
Mon, 23 Nov 2020 08:59:54 +0000 (09:59 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 24 Nov 2020 16:59:26 +0000 (17:59 +0100)
Commit 912c6b22fc622cd7c7d29c7f8eaeb816b266daac added abort() when the
'val' parameter is NULL along with setting the error variable for the
command. We don't want to abort in this case, just set the error.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/util/vircommand.c

index 9a4f3d7f32d23d95da793590e3da0d84a6e4e1ec..5117467c1d890b89a6b9fc3382992a4e2b32be66 100644 (file)
@@ -1503,7 +1503,7 @@ virCommandAddArg(virCommandPtr cmd, const char *val)
 
     if (val == NULL) {
         cmd->has_error = EINVAL;
-        abort();
+        return;
     }
 
     arg = g_strdup(val);