]> git.ipfire.org Git - thirdparty/dracut.git/commitdiff
fix(install): add a missing ret value assignment
authorFrantisek Sumsal <frantisek@sumsal.cz>
Fri, 18 Jun 2021 12:35:04 +0000 (14:35 +0200)
committerJóhann B. Guðmundsson <johannbg@gmail.com>
Mon, 28 Jun 2021 11:20:21 +0000 (11:20 +0000)
Spotted when reconfiguring LGTM for RHEL 9 dracut repo.

src/install/dracut-install.c

index 9a40e0220648bd20d19a329e7e2e5a245c23ed34..00a4f5867a88e4bac1817c32a08c8b0b0e8107ba 100644 (file)
@@ -1448,14 +1448,14 @@ static int install_firmware(struct kmod_module *mod)
                                 _cleanup_globfree_ glob_t globbuf;
                                 glob(fwpath, 0, NULL, &globbuf);
                                 for (i = 0; i < globbuf.gl_pathc; i++) {
-                                        install_firmware_fullpath(globbuf.gl_pathv[i]);
+                                        ret = install_firmware_fullpath(globbuf.gl_pathv[i]);
                                         if (ret != 0) {
                                                 log_info("Possible missing firmware %s for kernel module %s", value,
                                                          kmod_module_get_name(mod));
                                         }
                                 }
                         } else {
-                                install_firmware_fullpath(fwpath);
+                                ret = install_firmware_fullpath(fwpath);
                                 if (ret != 0) {
                                         log_info("Possible missing firmware %s for kernel module %s", value,
                                                  kmod_module_get_name(mod));