localedef: drop unused --old-style

The --old-style option for localedef is a no-op and has been for 16
years.  Delete the code.

diff --git a/ChangeLog b/ChangeLog
index 94caf576157aedcfb3bd101f608f96bef89754e8..e62235f5ecf8699d0334d27f05a0f5613db61022 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-06-11  Marko Myllynen  <myllynen@redhat.com>
+
+       * locale/programs/localedef.c (oldstyle_tables): Remove.
+       * locale/programs/localedef.h (oldstyle_tables): Likewise.
+
 2016-06-10  Joseph Myers  <joseph@codesourcery.com>
 
        [BZ #20240]

diff --git a/NEWS b/NEWS
index 9d6ac56d539dfcf7851e43abbde0be1b836bdd42..4334578c6e8a4583b27d1e7ab29113fb26664a19 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -36,6 +36,9 @@ Version 2.24
 * The deprecated __malloc_initialize_hook variable has been removed from the
   API.
 
+* The long unused --old-style flag has been removed.  It hasn't done anything
+  in over 16 years.  Scripts using this flag can safely drop it.
+
 Security related changes:
 
 * An unnecessary stack copy in _nss_dns_getnetbyname_r was removed.  It

diff --git a/locale/programs/localedef.c b/locale/programs/localedef.c
index bfc5d22eaec77999e0dc04d9b6be1b5d1b9e83b2..b4c48f17f631f563fe36bedbbf244cc5c573c0fa 100644 (file)
--- a/locale/programs/localedef.c
+++ b/locale/programs/localedef.c
@@ -54,10 +54,6 @@ int verbose;
 /* If not zero suppress warnings and information messages.  */
 int be_quiet;
 
-/* If not zero, produce old-style hash table instead of 3-level access
-   tables.  */
-int oldstyle_tables;
-
 /* If not zero force output even if warning were issued.  */
 static int force_output;
 
@@ -104,7 +100,6 @@ void (*argp_program_version_hook) (FILE *, struct argp_state *) = print_version;
 
 #define OPT_POSIX 301
 #define OPT_QUIET 302
-#define OPT_OLDSTYLE 303
 #define OPT_PREFIX 304
 #define OPT_NO_ARCHIVE 305
 #define OPT_ADD_TO_ARCHIVE 306
@@ -128,7 +123,6 @@ static const struct argp_option options[] =
   { NULL, 0, NULL, 0, N_("Output control:") },
   { "force", 'c', NULL, 0,
     N_("Create output even if warning messages were issued") },
-  { "old-style", OPT_OLDSTYLE, NULL, 0, N_("Create old-style tables") },
   { "prefix", OPT_PREFIX, N_("PATH"), 0, N_("Optional output file prefix") },
   { "posix", OPT_POSIX, NULL, 0, N_("Strictly conform to POSIX") },
   { "quiet", OPT_QUIET, NULL, 0,
@@ -310,9 +304,6 @@ parse_opt (int key, char *arg, struct argp_state *state)
     case OPT_POSIX:
       posix_conformance = 1;
       break;
-    case OPT_OLDSTYLE:
-      oldstyle_tables = 1;
-      break;
     case OPT_PREFIX:
       output_prefix = arg;
       break;

diff --git a/locale/programs/localedef.h b/locale/programs/localedef.h
index cb9386a79810dba32e17f8e06ef0d74c8922358b..daed933e6de6cd27be768aa2dc8f67e1f512e14c 100644 (file)
--- a/locale/programs/localedef.h
+++ b/locale/programs/localedef.h
@@ -112,7 +112,6 @@ struct localedef_t
 /* Global variables of the localedef program.  */
 extern int verbose;
 extern int be_quiet;
-extern int oldstyle_tables;
 extern const char *repertoire_global;
 extern int max_locarchive_open_retry;
 extern bool no_archive;