clk: renesas: Use IS_ERR() for pointers that cannot be NULL

The use of IS_ERR_OR_NULL() suggests that "clk" can be a NULL pointer.
Hence smatch assumes so, and issues a "passing zero to 'PTR_ERR'"
warning.

At these checkpoints, "clk" always contains either a valid pointer, or
an error pointer (none of the functions called return NULL pointers).
Hence replace IS_ERR_OR_NULL() by IS_ERR().

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202408032025.ve2JMaoV-lkp@intel.com/
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/81260328acb5c78e915ab04afad3901a31c16128.1758793709.git.geert+renesas@glider.be

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index a0a68ec0490f7cb40da79ce0f0d9a55ef97a9885..a3d171ddaab9923b79b09077ff9a48e529920cb7 100644 (file)
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -451,7 +451,7 @@ static void __init cpg_mssr_register_core_clk(const struct cpg_core_clk *core,
                break;
        }
 
-       if (IS_ERR_OR_NULL(clk))
+       if (IS_ERR(clk))
                goto fail;
 
        dev_dbg(dev, "Core clock %pC at %lu Hz\n", clk, clk_get_rate(clk));

diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
index 07909e80bae24e02a70324b49d9fd0df4097c55a..64d1ef6e4c943c910f5b43b330f66f9d91898326 100644 (file)
--- a/drivers/clk/renesas/rzg2l-cpg.c
+++ b/drivers/clk/renesas/rzg2l-cpg.c
@@ -1177,7 +1177,7 @@ rzg2l_cpg_register_core_clk(const struct cpg_core_clk *core,
                goto fail;
        }
 
-       if (IS_ERR_OR_NULL(clk))
+       if (IS_ERR(clk))
                goto fail;
 
        dev_dbg(dev, "Core clock %pC at %lu Hz\n", clk, clk_get_rate(clk));

diff --git a/drivers/clk/renesas/rzv2h-cpg.c b/drivers/clk/renesas/rzv2h-cpg.c
index 2197d1d2453a3f269388072a6c53d39f1a98bc5c..ff688dc88ba3e6a7a47749bbeca3c0f01b4c38c4 100644 (file)
--- a/drivers/clk/renesas/rzv2h-cpg.c
+++ b/drivers/clk/renesas/rzv2h-cpg.c
@@ -591,7 +591,7 @@ rzv2h_cpg_register_core_clk(const struct cpg_core_clk *core,
                goto fail;
        }
 
-       if (IS_ERR_OR_NULL(clk))
+       if (IS_ERR(clk))
                goto fail;
 
        dev_dbg(dev, "Core clock %pC at %lu Hz\n", clk, clk_get_rate(clk));