]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
oeqa/utils/commands: Avoid unclosed file warnings
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 13 Nov 2018 22:43:25 +0000 (22:43 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 13 Nov 2018 22:57:29 +0000 (22:57 +0000)
Avoid warnings such as:

meta/lib/oeqa/utils/commands.py:213: ResourceWarning: unclosed file <_io.BufferedReader name=4>
  return runCmd(cmd, ignore_status, timeout, output_log=output_log, **options)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/utils/commands.py

index 0d9cf23fe42131df0c62c2f17ddac1831a738037..01add686897c3e8f16aa392cd6426fd3eab4095b 100644 (file)
@@ -146,6 +146,9 @@ class Command(object):
         # At this point we know that the process has closed stdout/stderr, so
         # it is safe and necessary to wait for the actual process completion.
         self.status = self.process.wait()
+        self.process.stdout.close()
+        if self.process.stderr:
+            self.process.stderr.close()
 
         self.log.debug("Command '%s' returned %d as exit code." % (self.cmd, self.status))
         # logging the complete output is insane