]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
S390: Override QEMU_CAPS_NO_ACPI for s390x
authorViktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Fri, 22 Jun 2012 11:50:10 +0000 (13:50 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 25 Jun 2012 14:43:18 +0000 (16:43 +0200)
Starting a KVM guest on s390 fails immediately. This is because
"qemu --help" reports -no-acpi even for the s390(x) architecture but
-no-acpi isn't supported there.
Workaround is to remove QEMU_CAPS_NO_ACPI from the capability set
after the version/capability extraction.

Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
src/qemu/qemu_capabilities.c

index 578daebdb4b54c5347c64444b963b11d09f2bab9..1e12a3995c53fe1e4997e2e1d9918c350407ec62 100644 (file)
@@ -1514,6 +1514,11 @@ int qemuCapsExtractVersionInfo(const char *qemu, const char *arch,
         qemuCapsSet(flags, QEMU_CAPS_PCI_MULTIBUS);
     }
 
+    /* S390 and probably other archs do not support no-acpi -
+       maybe the qemu option parsing should be re-thought. */
+    if (STRPREFIX(arch, "s390"))
+        qemuCapsClear(flags, QEMU_CAPS_NO_ACPI);
+
     /* qemuCapsExtractDeviceStr will only set additional flags if qemu
      * understands the 0.13.0+ notion of "-device driver,".  */
     if (qemuCapsGet(flags, QEMU_CAPS_DEVICE) &&