]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: videobuf2-core: clear memory related fields in __vb2_plane_dmabuf_put()
authorYunke Cao <yunkec@chromium.org>
Wed, 14 Aug 2024 02:06:40 +0000 (11:06 +0900)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 14 Aug 2024 08:05:32 +0000 (10:05 +0200)
Clear vb2_plane's memory related fields in __vb2_plane_dmabuf_put(),
including bytesused, length, fd and data_offset.

Remove the duplicated code in __prepare_dmabuf().

Signed-off-by: Yunke Cao <yunkec@chromium.org>
Acked-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/common/videobuf2/videobuf2-core.c

index 0217392fcc0d9c92424d1e528b73d1778fee8be5..4d232b08f9505474aee234423a607db6848b8363 100644 (file)
@@ -311,6 +311,10 @@ static void __vb2_plane_dmabuf_put(struct vb2_buffer *vb, struct vb2_plane *p)
        p->mem_priv = NULL;
        p->dbuf = NULL;
        p->dbuf_mapped = 0;
+       p->bytesused = 0;
+       p->length = 0;
+       p->m.fd = 0;
+       p->data_offset = 0;
 }
 
 /*
@@ -1420,10 +1424,6 @@ static int __prepare_dmabuf(struct vb2_buffer *vb)
 
                /* Release previously acquired memory if present */
                __vb2_plane_dmabuf_put(vb, &vb->planes[plane]);
-               vb->planes[plane].bytesused = 0;
-               vb->planes[plane].length = 0;
-               vb->planes[plane].m.fd = 0;
-               vb->planes[plane].data_offset = 0;
 
                /* Acquire each plane's memory */
                mem_priv = call_ptr_memop(attach_dmabuf,