]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
fix dereference before null check warning
authorMark Andrews <marka@isc.org>
Thu, 14 Nov 2013 01:31:25 +0000 (12:31 +1100)
committerMark Andrews <marka@isc.org>
Thu, 14 Nov 2013 01:33:38 +0000 (12:33 +1100)
(cherry picked from commit 980097441934ea2c87fae44520abf1600029ea93)

bin/named/lwdgrbn.c

index 057eac91c941638fcabc4a346f1de8261fc5c927..f31923ba2cb68d078ad48494fd90e355f29558a6 100644 (file)
@@ -204,6 +204,8 @@ lookup_done(isc_task_t *task, isc_event_t *event) {
        lwres_grbnresponse_t *grbn;
        int i;
 
+       REQUIRE(event != NULL);
+
        UNUSED(task);
 
        lwb.base = NULL;
@@ -384,8 +386,7 @@ lookup_done(isc_task_t *task, isc_event_t *event) {
        if (lwb.base != NULL)
                lwres_context_freemem(cm->lwctx, lwb.base, lwb.length);
 
-       if (event != NULL)
-               isc_event_free(&event);
+       isc_event_free(&event);
 
        ns_lwdclient_log(50, "error constructing getrrsetbyname response");
        ns_lwdclient_errorpktsend(client, LWRES_R_FAILURE);