]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mailbox: exynos: drop unneeded runtime pointer (pclk)
authorAndré Draszik <andre.draszik@linaro.org>
Mon, 5 Jan 2026 12:34:35 +0000 (12:34 +0000)
committerJassi Brar <jassisinghbrar@gmail.com>
Sun, 25 Jan 2026 00:42:39 +0000 (18:42 -0600)
pclk is not needed past probe(), just drop it. This saves a little bit
of runtime memory.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/exynos-mailbox.c

index 2320649bf60c86980c0e8554f2d5fd32af218a6d..5f2d3b81c1dbec8d1a15353769b4b3a1d6ebdf21 100644 (file)
  * struct exynos_mbox - driver's private data.
  * @regs:      mailbox registers base address.
  * @mbox:      pointer to the mailbox controller.
- * @pclk:      pointer to the mailbox peripheral clock.
  */
 struct exynos_mbox {
        void __iomem *regs;
        struct mbox_controller *mbox;
-       struct clk *pclk;
 };
 
 static int exynos_mbox_send_data(struct mbox_chan *chan, void *data)
@@ -100,6 +98,7 @@ static int exynos_mbox_probe(struct platform_device *pdev)
        struct exynos_mbox *exynos_mbox;
        struct mbox_controller *mbox;
        struct mbox_chan *chans;
+       struct clk *pclk;
        int i;
 
        exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL);
@@ -119,9 +118,9 @@ static int exynos_mbox_probe(struct platform_device *pdev)
        if (IS_ERR(exynos_mbox->regs))
                return PTR_ERR(exynos_mbox->regs);
 
-       exynos_mbox->pclk = devm_clk_get_enabled(dev, "pclk");
-       if (IS_ERR(exynos_mbox->pclk))
-               return dev_err_probe(dev, PTR_ERR(exynos_mbox->pclk),
+       pclk = devm_clk_get_enabled(dev, "pclk");
+       if (IS_ERR(pclk))
+               return dev_err_probe(dev, PTR_ERR(pclk),
                                     "Failed to enable clock.\n");
 
        mbox->num_chans = EXYNOS_MBOX_CHAN_COUNT;