ntp_crypto.c:

  close stream when error occur (Coverity NetBSD Scan CID 2054)

bk: 441bca82b_Uk4tzXdcAe0-NqQMN37w

diff --git a/ntpd/ntp_crypto.c b/ntpd/ntp_crypto.c
index a17c95cf523b08bb37ee66e04b0923551cd1cca9..f0aa1b9093adb5c4912d2147f657fe2426cad33b 100644 (file)
--- a/ntpd/ntp_crypto.c
+++ b/ntpd/ntp_crypto.c
@@ -3565,16 +3565,19 @@ crypto_key(
        if ((ptr = fgets(linkname, MAXFILENAME, str)) == NULL) {
                msyslog(LOG_ERR, "crypto_key: no data %s\n",
                    filename);
+               (void)fclose(str);
                return (NULL);
        }
        if ((ptr = strrchr(ptr, '.')) == NULL) {
                msyslog(LOG_ERR, "crypto_key: no filestamp %s\n",
                    filename);
+               (void)fclose(str);
                return (NULL);
        }
        if (sscanf(++ptr, "%u", fstamp) != 1) {
                msyslog(LOG_ERR, "crypto_key: invalid timestamp %s\n",
                    filename);
+               (void)fclose(str);
                return (NULL);
        }