]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
cpupower: idle_monitor: fix incorrect value logged after stop
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Tue, 2 Dec 2025 04:40:12 +0000 (10:10 +0530)
committerShuah Khan <skhan@linuxfoundation.org>
Mon, 15 Dec 2025 19:33:28 +0000 (12:33 -0700)
The cpuidle sysfs monitor printed the previous sample’s counter
value in cpuidle_stop() instead of the freshly read one. The dprint
line used previous_count[cpu][state] while current_count[cpu][state]
had just been populated. This caused misleading debug output.

Switch the logging to current_count so the post-interval snapshot
matches the displayed value.

Link: https://lore.kernel.org/r/20251202044012.3844790-1-kaushlendra.kumar@intel.com
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c

index 8b42c2f0a5b0f485d7cb249830e4cf9a913d19e0..4225eff9833d9fabb199e032645836ca03a1dc0d 100644 (file)
@@ -70,7 +70,7 @@ static int cpuidle_stop(void)
                        current_count[cpu][state] =
                                cpuidle_state_time(cpu, state);
                        dprint("CPU %d - State: %d - Val: %llu\n",
-                              cpu, state, previous_count[cpu][state]);
+                              cpu, state, current_count[cpu][state]);
                }
        }
        return 0;