]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Second element of find and findOne should be optional, not the first one
authorJohann-S <johann.servoire@gmail.com>
Sat, 26 Aug 2017 22:57:27 +0000 (00:57 +0200)
committerXhmikosR <xhmikosr@gmail.com>
Wed, 20 Feb 2019 20:05:45 +0000 (22:05 +0200)
js/src/alert.js
js/src/dom/selectorEngine.js

index d23c4659c01126c09f82416b5614f37fedef7b41..1bdd9706a46dc5a9ec06676ad521c13742b3c840 100644 (file)
@@ -84,7 +84,7 @@ class Alert {
     let parent     = false
 
     if (selector) {
-      parent = SelectorEngine.find(selector)[0]
+      parent = SelectorEngine.findOne(selector)
     }
 
     if (!parent) {
index bef6169884553a0cbd98a12eead4b54edfe4dcf7..0cff83ef9784f5dc1471e3d82d7170164325d5ea 100644 (file)
@@ -46,19 +46,19 @@ const SelectorEngine = {
     return fnMatches.call(element, selector)
   },
 
-  find(element = document, selector) {
+  find(selector, element = document) {
     if (typeof selector !== 'string') {
       return null
     }
 
     if (selector.indexOf('#') === 0) {
-      return SelectorEngine.findOne(element, selector)
+      return SelectorEngine.findOne(selector, element)
     }
 
     return element.querySelectorAll(selector)
   },
 
-  findOne(element = document, selector) {
+  findOne(selector, element = document) {
     if (typeof selector !== 'string') {
       return null
     }