]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
test: Remove unnecessary unlocks in cleanup paths
authorJohn Ferlan <jferlan@redhat.com>
Fri, 14 Apr 2017 13:24:33 +0000 (09:24 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Tue, 25 Apr 2017 12:16:00 +0000 (08:16 -0400)
Commit id '865f479da' altered the logic to use a common test*ObjFindByName
helpers which would lock/unlock the test driver; however, a few cleanup paths
in that cleanup missed removing the Unlock, so remove it now.

Signed-off-by: John Ferlan <jferlan@redhat.com>
src/test/test_driver.c

index 00999b116107f418aef209c85ba62f79dc13fa86..2db3f7ddfe9ca62cb9344d2baf3b6db483047dd0 100644 (file)
@@ -3931,7 +3931,6 @@ testInterfaceUndefine(virInterfacePtr iface)
     ret = 0;
 
  cleanup:
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -3960,7 +3959,6 @@ testInterfaceCreate(virInterfacePtr iface,
  cleanup:
     if (privinterface)
         virInterfaceObjUnlock(privinterface);
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -3989,7 +3987,6 @@ testInterfaceDestroy(virInterfacePtr iface,
  cleanup:
     if (privinterface)
         virInterfaceObjUnlock(privinterface);
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -4480,7 +4477,6 @@ testStoragePoolUndefine(virStoragePoolPtr pool)
     if (privpool)
         virStoragePoolObjUnlock(privpool);
     testObjectEventQueue(privconn, event);
-    testDriverUnlock(privconn);
     return ret;
 }
 
@@ -4591,7 +4587,6 @@ testStoragePoolDestroy(virStoragePoolPtr pool)
     testObjectEventQueue(privconn, event);
     if (privpool)
         virStoragePoolObjUnlock(privpool);
-    testDriverUnlock(privconn);
     return ret;
 }