]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: asymmetric_keys - remove always false comparison
authorsudip <sudipm.mukherjee@gmail.com>
Thu, 17 Sep 2015 07:42:51 +0000 (13:12 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Dec 2015 23:11:25 +0000 (18:11 -0500)
commit 4dd17c9c8a30c8d8cd1c9d4b94f08aca4b038d3e upstream.

hour, min and sec are unsigned int and they can never be less than zero.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/asymmetric_keys/x509_cert_parser.c

index af71878dc15bfff17dd34200a08be48633ceea9b..3000ea3b6687451df7b5459e01cbf4215f9e9c85 100644 (file)
@@ -546,9 +546,9 @@ int x509_decode_time(time64_t *_t,  size_t hdrlen,
        if (year < 1970 ||
            mon < 1 || mon > 12 ||
            day < 1 || day > mon_len ||
-           hour < 0 || hour > 23 ||
-           min < 0 || min > 59 ||
-           sec < 0 || sec > 59)
+           hour > 23 ||
+           min > 59 ||
+           sec > 59)
                goto invalid_time;
        
        *_t = mktime64(year, mon, day, hour, min, sec);