]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virLockSpacePreExecRestart: Avoid use-after-free
authorPeter Krempa <pkrempa@redhat.com>
Fri, 12 Mar 2021 09:12:51 +0000 (10:12 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 12 Mar 2021 10:02:35 +0000 (11:02 +0100)
Recent refactor marked 'object' which is returned from the function as
autofree but forgot to use g_steal_pointer in the return statement to
prevent freeing it.

Fixes: 9a1651f64d7
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/util/virlockspace.c

index f253091f39a565f6bb0d36f2ec39556c694c6751..9e80db6a0c96c8f0af9b75c95ecf56413d5155a4 100644 (file)
@@ -472,7 +472,7 @@ virJSONValuePtr virLockSpacePreExecRestart(virLockSpacePtr lockspace)
         goto error;
 
     virMutexUnlock(&lockspace->lock);
-    return object;
+    return g_steal_pointer(&object);
 
  error:
     virMutexUnlock(&lockspace->lock);