]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: typec: fusb302: Switch to threaded IRQ handler
authorAlexey Charkov <alchark@flipper.net>
Tue, 17 Mar 2026 16:30:15 +0000 (20:30 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Mar 2026 14:53:30 +0000 (16:53 +0200)
FUSB302 fails to probe with -EINVAL if its interrupt line is connected via
an I2C GPIO expander, such as TI TCA6416.

Switch the interrupt handler to a threaded one, which also works behind
such GPIO expanders.

Cc: stable <stable@kernel.org>
Fixes: 309b6341d557 ("usb: typec: fusb302: Revert incorrect threaded irq fix")
Signed-off-by: Alexey Charkov <alchark@flipper.net>
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Reviewed-by: Heikki Krogerus <heikki.krogrerus@linux.intel.com>
Link: https://patch.msgid.link/20260317-fusb302-irq-v2-1-dbabd5c5c961@flipper.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/fusb302.c

index ce7069fb4be6931ce496f4181080730f6a12f67b..889c4c29c1b806c74e1cfd54e0a5bc413a31a778 100644 (file)
@@ -1764,8 +1764,9 @@ static int fusb302_probe(struct i2c_client *client)
                goto destroy_workqueue;
        }
 
-       ret = request_irq(chip->gpio_int_n_irq, fusb302_irq_intn,
-                         IRQF_TRIGGER_LOW, "fsc_interrupt_int_n", chip);
+       ret = request_threaded_irq(chip->gpio_int_n_irq, NULL, fusb302_irq_intn,
+                                  IRQF_ONESHOT | IRQF_TRIGGER_LOW,
+                                  "fsc_interrupt_int_n", chip);
        if (ret < 0) {
                dev_err(dev, "cannot request IRQ for GPIO Int_N, ret=%d", ret);
                goto tcpm_unregister_port;