libsamba-errors: eliminate dependency on samba-debug

libsamba-errors is a collection of error codes/descriptions
like strerror(), - it is a set of simple functions converting
error code to string or the like.  However, in one single
place there's a DBG_DEBUG() "call" in errmap_unix.c, in
map_errno_from_nt_status(), which is here for a very long time
(since before samba3, initially with debug level 10).

Drop this debugging info, and eliminate extra dependency.
This makes libsamba-errors independent and self-contained,
with a well-known and stable ABI.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>

diff --git a/libcli/util/errmap_unix.c b/libcli/util/errmap_unix.c
index 16c7b4916e75f71d8ba42148d84930d14095f4a7..60e570cca902871da48da190ff84ef08b7d67852 100644 (file)
--- a/libcli/util/errmap_unix.c
+++ b/libcli/util/errmap_unix.c
@@ -277,10 +277,7 @@ int map_errno_from_nt_status(NTSTATUS status)
 {
        size_t i;
 
-       DBG_DEBUG("32 bit codes: code=%08x\n", NT_STATUS_V(status));
-
        /* Status codes without this bit set are not errors */
-
        if (!(NT_STATUS_V(status) & 0xc0000000)) {
                return 0;
        }

diff --git a/libcli/util/wscript_build b/libcli/util/wscript_build
index 64bd21e19ca74e0284fe1add23b5ef5b0445f7ee..19c5d3bd24eede1adecab7e6fe7b8554c8d45339 100644 (file)
--- a/libcli/util/wscript_build
+++ b/libcli/util/wscript_build
@@ -6,7 +6,7 @@ bld.SAMBA_LIBRARY('samba-errors',
                   private_headers='nterr_private.h',
                   header_path='core',
                   source='doserr.c errormap.c nterr.c errmap_unix.c hresult.c',
-                  public_deps='talloc samba-debug',
+                  public_deps='talloc',
                   deps='gnutls',
                   # private_library=True,
                   pc_files=[],