]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: chips-media: wave5: Fix gray color on screen
authorJackson.lee <jackson.lee@chipsnmedia.com>
Tue, 17 Dec 2024 04:51:22 +0000 (13:51 +0900)
committerHans Verkuil <hverkuil@xs4all.nl>
Sat, 15 Feb 2025 10:18:42 +0000 (11:18 +0100)
When a decoder instance is created, the W5_CMD_ERR_CONCEAL register
should be initialized to 0. Otherwise, gray color is occasionally
displayed on the screen while decoding.

Fixes: 45d1a2b93277 ("media: chips-media: wave5: Add vpuapi layer")
Cc: stable@vger.kernel.org
Signed-off-by: Jackson.lee <jackson.lee@chipsnmedia.com>
Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/chips-media/wave5/wave5-hw.c

index c8a90599410980142ce48df568cc1dbe0d2d5f7c..d94cf84c3ee5fc882a3da94ede68af15ae850b99 100644 (file)
@@ -585,7 +585,7 @@ int wave5_vpu_build_up_dec_param(struct vpu_instance *inst,
                vpu_write_reg(inst->dev, W5_CMD_NUM_CQ_DEPTH_M1,
                              WAVE521_COMMAND_QUEUE_DEPTH - 1);
        }
-
+       vpu_write_reg(inst->dev, W5_CMD_ERR_CONCEAL, 0);
        ret = send_firmware_command(inst, W5_CREATE_INSTANCE, true, NULL, NULL);
        if (ret) {
                wave5_vdi_free_dma_memory(vpu_dev, &p_dec_info->vb_work);