app_dial: Immediately exit dial if the caller is already hung up.

If a caller hangs up before dial is executed within an AGI then the AGI
has likely eaten all queued frames before executing the dial in DeadAGI
mode.  With the caller hung up and no pending frames from the caller's
read queue, dial would not know that the call has hung up until a called
channel answers.  It is rather annoying to whoever just answered the
non-existent call.

Dial should not continue execution in DeadAGI mode, hangup handlers, or
the h exten.

* Added a check early in dial to abort dialing if the caller has hungup.

ASTERISK-25307 #close
Reported by: David Cunningham

Change-Id: Icd1bc0764726ef8c809f76743ca008d0f102f418

diff --git a/apps/app_dial.c b/apps/app_dial.c
index 4311e45f8675ff3e07f565f5d1dfb979e616a911..278a27474085ecbcbbc12511a847bf291a0e4ae3 100644 (file)
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -2127,6 +2127,24 @@ static int dial_exec_full(struct ast_channel *chan, const char *data, struct ast
                return -1;
        }
 
+       if (ast_check_hangup_locked(chan)) {
+               /*
+                * Caller hung up before we could dial.  If dial is executed
+                * within an AGI then the AGI has likely eaten all queued
+                * frames before executing the dial in DeadAGI mode.  With
+                * the caller hung up and no pending frames from the caller's
+                * read queue, dial would not know that the call has hung up
+                * until a called channel answers.  It is rather annoying to
+                * whoever just answered the non-existent call.
+                *
+                * Dial should not continue execution in DeadAGI mode, hangup
+                * handlers, or the h exten.
+                */
+               ast_verb(3, "Caller hung up before dial.\n");
+               pbx_builtin_setvar_helper(chan, "DIALSTATUS", "CANCEL");
+               return -1;
+       }
+
        parse = ast_strdupa(data);
 
        AST_STANDARD_APP_ARGS(args, parse);